Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade cf cli #6114

Merged
merged 1 commit into from
Feb 4, 2025
Merged

upgrade cf cli #6114

merged 1 commit into from
Feb 4, 2025

Conversation

pkfec
Copy link
Contributor

@pkfec pkfec commented Jan 28, 2025

Summary

The Cloud.gov v2 API for Cloud Foundry is reaching its end-of-life. CF CLI versions 6 and 7 still rely on Cloud Foundry API v2 and will no longer work at some point with foundations that have disabled it. However, CF CLI v8 no longer uses Cloud FoundryAPI v2. For more details, refer to this link.

circleci/config.yml, is upgraded to CF CLI v8.9.0. This version supports Cloud Foundry API v3. Deploying to a cloud.gov space should work smoothly with this update.

Resolves #6110

Required reviewers

1 developer

Impacted areas of the application

General components of the application that this PR will affect:

  • install cf cli section
  • deploy api (to cloud.gov space)

Screenshots

Before:
cf cli v7.1.0 circleci build

Screenshot 2025-01-28 at 3 57 08 PM

After:
cf cli v8.9.0 circleci build

Screenshot 2025-01-28 at 2 44 00 PM Screenshot 2025-01-28 at 2 44 39 PM

Related PRs

Related PRs against other branches:

How to test

  • Follow these instructions to install cf CLI v8 on your local terminal or run: brew install cloudfoundry/tap/cf-cli@8
  • verify cf cli version: run cf version
F612211M:~ pkasireddy$ cf version
cf version 8.9.0+c23186c.2024-12-02
  • rerun this build in circleci
  • OR
  • create a test branch, update tasks.py(DEPLOY_RULES) with the test branch and deploy to dev space
  • Observe the following in circleci:
    1. In install cf cli section, verify that cf cli v8.9.0 is downloaded and no errors there
    1. In deploy api section, verify that api app deployed to cloud.space successfully without any errors
    1. Indeploy api section` confirm that API app is using Cloud Foundry v3 API:
API endpoint:   https://api.fr.cloud.gov
API version:    3.185.0

@pkfec pkfec self-assigned this Jan 28, 2025
@pkfec pkfec marked this pull request as draft January 28, 2025 20:17
@pkfec pkfec force-pushed the feature/6110-upgrade-cf-cli branch from 2c97ef0 to 5f95bee Compare January 29, 2025 17:35
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (669f921) to head (5f95bee).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6114   +/-   ##
========================================
  Coverage    88.53%   88.53%           
========================================
  Files           82       82           
  Lines         9176     9176           
========================================
  Hits          8124     8124           
  Misses        1052     1052           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Thanks

Copy link
Member

@cnlucas cnlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks @pkfec

@cnlucas cnlucas merged commit 3ef1ce9 into develop Feb 4, 2025
3 checks passed
@cnlucas cnlucas deleted the feature/6110-upgrade-cf-cli branch February 4, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

CF upgrade for deploys across all repos
3 participants